[libcxx-commits] [PATCH] D97323: [libcxx] Fix infinite loop regression when building libc++ with ubsan

Tue Feb 23 17:52:45 PST 2021

thakis added a comment.

In D97323#2583597 <https://reviews.llvm.org/D97323#2583597>, @ldionne wrote:

> In D97323#2582883 <https://reviews.llvm.org/D97323#2582883>, @rsmith wrote:
>
>> The ubsan runtime expects its dependencies to not have ubsan enabled. How are you configuring your build so that libc++abi ends up ubsan-instrumented? Can we ensure that doesn't happen somehow?
>
> In that case, I think we should fix the issue at its root and not make this workaround in libc++.
>
> Is there a way we could detect this sort of issue in the sanitizers to error early instead of just misbehaving when someone violates that requirement?

If the review feedback on D52386 <https://reviews.llvm.org/D52386> gets addressed, we could add an `#if __has_feature(ubsan_vptr) #error` to private_typeinfo.cpp.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97323/new/

https://reviews.llvm.org/D97323