[libcxx-commits] [PATCH] D97323: [libcxx] Fix infinite loop regression when building libc++ with ubsan
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Feb 23 17:26:39 PST 2021
ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.
In D97323#2582883 <https://reviews.llvm.org/D97323#2582883>, @rsmith wrote:
> The ubsan runtime expects its dependencies to not have ubsan enabled. How are you configuring your build so that libc++abi ends up ubsan-instrumented? Can we ensure that doesn't happen somehow?
In that case, I think we should fix the issue at its root and not make this workaround in libc++.
Is there a way we could detect this sort of issue in the sanitizers to error early instead of just misbehaving when someone violates that requirement?
CHANGES SINCE LAST ACTION
More information about the libcxx-commits