[libcxx-commits] [PATCH] D97294: [libcxx] [test] Add a MinGW target

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/utils/libcxx/test/target_info.py:25
     def platform(self):
         return sys.platform.lower().strip()
 
----------------
rnk wrote:
> I see, so the existing notion of target info is based on Python's sys.platform, which doesn't distinguish between mingw or MSVC environments.
Yes, and furthermore, as we might use a msys2/mingw based python to run tests for an msvc build, it isn't necessarily indicative anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97294/new/

https://reviews.llvm.org/D97294