[libcxx-commits] [PATCH] D97294: [libcxx] [test] Add a MinGW target

Reid Kleckner via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 23 10:38:25 PST 2021


rnk accepted this revision.
rnk added a comment.

lgtm



================
Comment at: libcxx/utils/libcxx/test/target_info.py:25
     def platform(self):
         return sys.platform.lower().strip()
 
----------------
I see, so the existing notion of target info is based on Python's sys.platform, which doesn't distinguish between mingw or MSVC environments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97294/new/

https://reviews.llvm.org/D97294



More information about the libcxx-commits mailing list