[libcxx-commits] [PATCH] D97166: [libcxx] [docs] Update docs about how to build for Windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

Thanks for having a look!



================
Comment at: libcxx/docs/BuildingLibcxx.rst:76-78
+cl doesn't support the `#include_next` extension. Furthermore, VS 2015 or
+newer (19.00) is required.
+
----------------
rnk wrote:
> I would update this to "VS 2017 or newer (19.14) is required", to be in line with the cmake checks in LLVM, which look for _MSC_VER 19.14.
I guess so, yeah, this is a bit old...


================
Comment at: libcxx/docs/BuildingLibcxx.rst:90
   > cmake -G "Visual Studio 14 2015"              ^
           -T "LLVM-vs2014"                        ^
           -DLIBCXX_ENABLE_SHARED=YES              ^
----------------
rnk wrote:
> I'm not sure what this should be. =/
I'll see if I can try actually running this config - I don't really see it as something that is used much, but I wouldn't want to remove it either.


================
Comment at: libcxx/docs/BuildingLibcxx.rst:111
+`\msys64\msys2_shell.cmd -full-path -mingw64` (preserving the earlier
+environment, allowing the MSVC headers/libraries and clang-cl to be found).
 
----------------
@rnk - Does this match how you generally build/run tests for other llvm components these days, or do you use some other provider of a unix shell, or do the rest of the tests cope with just a plain cmd shell?

At least for the libcxx tests, running tests in a cmd shell errors out like this:
```
Script:
--
echo 'COMPILED WITH' > nul &&  'C:/Program Files/LLVM/bin\clang++.EXE' ...

--
Exit Code: 9009

Command Output (stderr):
--
''C:' is not recognized as an internal or external command,
operable program or batch file.

```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97166/new/

https://reviews.llvm.org/D97166