[libcxx-commits] [PATCH] D97166: [libcxx] [docs] Update docs about how to build for Windows

[Reid Kleckner via Phabricator via libcxx-commits]

rnk added inline comments.


================
Comment at: libcxx/docs/BuildingLibcxx.rst:76-78
+cl doesn't support the `#include_next` extension. Furthermore, VS 2015 or
+newer (19.00) is required.
+
----------------
I would update this to "VS 2017 or newer (19.14) is required", to be in line with the cmake checks in LLVM, which look for _MSC_VER 19.14.


================
Comment at: libcxx/docs/BuildingLibcxx.rst:89
 
   > cmake -G "Visual Studio 14 2015"              ^
           -T "LLVM-vs2014"                        ^
----------------
I guess this becomes "Visual Studio 15 2017"


================
Comment at: libcxx/docs/BuildingLibcxx.rst:90
   > cmake -G "Visual Studio 14 2015"              ^
           -T "LLVM-vs2014"                        ^
           -DLIBCXX_ENABLE_SHARED=YES              ^
----------------
I'm not sure what this should be. =/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97166/new/

https://reviews.llvm.org/D97166