[libcxx-commits] [PATCH] D96523: [libc++] Rewrite the tuple constructors to be strictly Standards conforming

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 18 08:07:29 PST 2021

ldionne added a comment.

I think I'd land this patch as-is and then try to identify some instantiations we want to remove and do that. Arthur, thanks for taking us back on track :-).

I'll need to figure out what the issue is with the remaining tests that fail in C++11 and C++14. Then I'll land this patch internally at Apple in a test build and see if there's any breakage. If that all works, I'll land this here.

Comment at: libcxx/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/deduct.pass.cpp:16
 // against libstdc++.
-// XFAIL: gcc-5, gcc-6, gcc-7
+// XFAIL: gcc-5, gcc-6, gcc-7, gcc-9, gcc-10
Quuxplusone wrote:
> What about gcc-8?
> And does this patch change something that //breaks// gcc-9 and gcc-10, or is it more like "we never tested it and I just now noticed that it's broken"?  Maybe this belongs in a severable commit.
I forgot to add gcc-8, I'll do that.

This patch causes GCC 10 to segfault when CTAD is used.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list