[libcxx-commits] [PATCH] D96523: [libc++] Rewrite the tuple constructors to be strictly Standards conforming

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added a comment.

> Your example is broken - it SFINAEs out because you're zipping parameter packs of different lengths. See https://godbolt.org/z/qna759.

Oh, I thought you were saying that it wouldn't work because zipping parameter packs of different sizes would be a hard error. Anyway, I think I see what you're saying now. Thanks for the Godbolt link.

---

I think @Quuxplusone makes a good point. And for what it's worth, I'd be fine with this patch landing in its current state. I think we should attempt to remove extra template instantiations, but this can also be done after the fact and AFAICT this is already better than `main` (or at least easier to grok).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96523/new/

https://reviews.llvm.org/D96523