[libcxx-commits] [PATCH] D96683: [libcxx] adds concept `std::common_with`

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added inline comments.


================
Comment at: libcxx/test/std/concepts/lang/common.compile.pass.cpp:286
+
+struct T1 {};
+static_assert(!std::convertible_to<DullCommonType, T1>);
----------------
miscco wrote:
> I would greatly prefer if we could give those types names that describe what we are checking rather than numbers where one has to read the source an the standard
> 
The interesting information is in all the `CommonTypeX`s. `Tn` really just facilitates the common types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96683/new/

https://reviews.llvm.org/D96683