[libcxx-commits] [PATCH] D96683: [libcxx] adds concept `std::common_with`

Michael Schellenberger Costa via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Feb 14 23:51:33 PST 2021


miscco added inline comments.


================
Comment at: libcxx/test/std/concepts/lang/common.compile.pass.cpp:286
+
+struct T1 {};
+static_assert(!std::convertible_to<DullCommonType, T1>);
----------------
I would greatly prefer if we could give those types names that describe what we are checking rather than numbers where one has to read the source an the standard



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96683/new/

https://reviews.llvm.org/D96683



More information about the libcxx-commits mailing list