[libcxx-commits] [PATCH] D96560: libunwind: Don't attempt to authenticate a null return address.
Ryan Prichard via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Feb 11 18:25:38 PST 2021
rprichard added a comment.
In D96560#2558737 <https://reviews.llvm.org/D96560#2558737>, @pcc wrote:
> In D96560#2558596 <https://reviews.llvm.org/D96560#2558596>, @rprichard wrote:
>
>> It seems OK to me. Does it make sense to also skip (pc == 0) in UnwindCursor<A, R>::setInfoForSigReturn?
>
> Hmm, that seems redundant with the check that I'm adding here. Let's start with one and we can reconsider if we find another bug here.
Oh, yeah, it would be redundant with this check earlier in setInfoBasedOnIPRegister:
// Exit early if at the top of the stack.
if (pc == 0) {
_unwindInfoMissing = true;
return;
}
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96560/new/
https://reviews.llvm.org/D96560
More information about the libcxx-commits
mailing list