[libcxx-commits] [PATCH] D96560: libunwind: Don't attempt to authenticate a null return address.

Peter Collingbourne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 11 18:02:17 PST 2021


pcc added a comment.

In D96560#2558596 <https://reviews.llvm.org/D96560#2558596>, @rprichard wrote:

> It seems OK to me. Does it make sense to also skip (pc == 0) in UnwindCursor<A, R>::setInfoForSigReturn?

Hmm, that seems redundant with the check that I'm adding here. Let's start with one and we can reconsider if we find another bug here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96560/new/

https://reviews.llvm.org/D96560



More information about the libcxx-commits mailing list