[libcxx-commits] [PATCH] D96477: [libcxx] adds remaining callable concepts

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb marked 2 inline comments as done.
cjdb added inline comments.


================
Comment at: libcxx/test/std/concepts/callable/functions.h:8
 //===----------------------------------------------------------------------===//
-#ifndef CALLABLE_FUNCTIONS_H
-#define CALLABLE_FUNCTIONS_H
+#ifndef TEST_STD_CONCEPTS_LAND_CALLABLE_FUNCTIONS_H
+#define TEST_STD_CONCEPTS_LAND_CALLABLE_FUNCTIONS_H
----------------
curdeius wrote:
> `LAND_` should be removed, nope?
See @ldionne's request in D96230.


================
Comment at: libcxx/test/std/concepts/callable/predicate.compile.pass.cpp:94
+}
\ No newline at end of file

----------------
curdeius wrote:
> Nit: newline.
Done, but not pushing to remote since it's not worth activating CI for this.


================
Comment at: libcxx/test/std/concepts/callable/strictweakorder.compile.pass.cpp:102
+}
\ No newline at end of file

----------------
curdeius wrote:
> Newline.
Done, as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96477/new/

https://reviews.llvm.org/D96477