[libcxx-commits] [PATCH] D96477: [libcxx] adds remaining callable concepts

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 11 06:23:25 PST 2021


curdeius added a comment.

Nits only for the moment.



================
Comment at: libcxx/test/std/concepts/callable/functions.h:8
 //===----------------------------------------------------------------------===//
-#ifndef CALLABLE_FUNCTIONS_H
-#define CALLABLE_FUNCTIONS_H
+#ifndef TEST_STD_CONCEPTS_LAND_CALLABLE_FUNCTIONS_H
+#define TEST_STD_CONCEPTS_LAND_CALLABLE_FUNCTIONS_H
----------------
`LAND_` should be removed, nope?


================
Comment at: libcxx/test/std/concepts/callable/predicate.compile.pass.cpp:94
+}
\ No newline at end of file

----------------
Nit: newline.


================
Comment at: libcxx/test/std/concepts/callable/strictweakorder.compile.pass.cpp:102
+}
\ No newline at end of file

----------------
Newline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96477/new/

https://reviews.llvm.org/D96477



More information about the libcxx-commits mailing list