[libcxx-commits] [PATCH] D96230: [libcxx] adds concept `std::move_constructible`

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM after you've considered my comments. You can update the review if you want to re-trigger CI, but no need to wait for my approval. This is great, thanks!



================
Comment at: libcxx/test/std/concepts/lang/moveconstructible.compile.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
Should this test be named `move_constructible.compile.pass.cpp` instead?


================
Comment at: libcxx/test/std/concepts/lang/moveconstructible.compile.pass.cpp:21
+int main(int, char**) {
+  static_assert(std::move_constructible<int>);
+  static_assert(std::move_constructible<int*>);
----------------
You can move those out of `main()` since they are just `static_assert`s.


================
Comment at: libcxx/test/std/concepts/lang/moveconstructible.h:8
+//===----------------------------------------------------------------------===//
+#ifndef MOVECONSTRUCTIBLE_H
+#define MOVECONSTRUCTIBLE_H
----------------
Please use `TEST_STD_CONCEPTS_LAND_MOVECONSTRUCTIBLE_H` or something that more clearly encodes the path of the file. Nitpicky :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96230/new/

https://reviews.llvm.org/D96230