[libcxx-commits] [PATCH] D96230: [libcxx] adds concept `std::move_constructible`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.

In D96230#2550352 <https://reviews.llvm.org/D96230#2550352>, @cjdb wrote:

> In D96230#2548903 <https://reviews.llvm.org/D96230#2548903>, @Mordante wrote:
>
>> Do we need to do some tests on
>> [concept.moveconstructible]/1 http://eel.is/c++draft/concepts#concept.moveconstructible-1 ? Or does `constructible_­from` and `convertible_­to` guarantee these conditions hold?
>
> The compiler doesn't check the semantic requirements (right now), so there's nothing to test. If we decide to promote violating the semantic requirements from IFNDR to ill-formed, that's when adding the tests will be helpful (right now they'd likely get in the way).

SGTM. Just a bit surprised the Standard doesn't require more tests. Especially surprised by `std::invocable` and `std::regular_invocable` that they're the same. But I assume it has something to do with hard to validate.

No more comment, so LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96230/new/

https://reviews.llvm.org/D96230