[libcxx-commits] [PATCH] D116198: [libc++] [test] [NFC] Flatten the directory structure a bit

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for your input.

In D116198#3212839 <https://reviews.llvm.org/D116198#3212839>, @ldionne wrote:

> In D116198#3212588 <https://reviews.llvm.org/D116198#3212588>, @Quuxplusone wrote:
>
>> @Mordante suggested that it might be better to name the test files after the corresponding stablenames, instead of the corresponding library identifiers:
>>
>>   begin.pass.cpp => range.access.begin.pass.cpp
>>   end.pass.cpp => range.access.end.pass.cpp
>>   data.pass.cpp => range.prim.data.pass.cpp
>>   empty.pass.cpp => range.prim.empty.pass.cpp
>>   size.pass.cpp => range.prim.size.pass.cpp
>>   ssize.pass.cpp => range.prim.ssize.pass.cpp
>
> I'm not a huge fan of this either, for the same reasons you stated. It would be more consistent if we did this throughout, though, but it would be a pretty big change (a simple change but it would touch a lot of files). Today, we basically use section names except for the leaf name where we use "whatever makes sense", or at least that's how I would codify what I think we're doing.

I basically wanted that style since it keeps the omitted section names, including the odd "prim". But I've no objection against the shorter names.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116198/new/

https://reviews.llvm.org/D116198