[libcxx-commits] [PATCH] D116198: [libc++] [test] [NFC] Flatten the directory structure a bit

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D116198#3212588 <https://reviews.llvm.org/D116198#3212588>, @Quuxplusone wrote:

> In D116198#3212553 <https://reviews.llvm.org/D116198#3212553>, @ldionne wrote:
>
>> Can someone summarize the discussion? Previously the test paths were mirroring section names in the standard. I'd like to understand what the proposed naming scheme is.
>
> The new test paths mirror the section names in the standard: everything that is specified under http://eel.is/c++draft/range.access is now located under `libcxx/test/*/ranges/range.access/`.
> [...]
> The old test paths were kind of wonky, because they included subdirectory components that didn't mirror the standard's stablenames. E.g. `data`, `size`, and `ssize` were previously tested under the subdirectory `libcxx/test/std/ranges/range.access/range.prim/`, but there is no https://eel.is/c++draft/range.prim in the standard.

Okay, in that case my affirmation above was wrong. Thanks for clarifying.

> @Mordante suggested that it might be better to name the test files after the corresponding stablenames, instead of the corresponding library identifiers:
>
>   begin.pass.cpp => range.access.begin.pass.cpp
>   end.pass.cpp => range.access.end.pass.cpp
>   data.pass.cpp => range.prim.data.pass.cpp
>   empty.pass.cpp => range.prim.empty.pass.cpp
>   size.pass.cpp => range.prim.size.pass.cpp
>   ssize.pass.cpp => range.prim.ssize.pass.cpp

I'm not a huge fan of this either, for the same reasons you stated. It would be more consistent if we did this throughout, though, but it would be a pretty big change (a simple change but it would touch a lot of files). Today, we basically use section names except for the leaf name where we use "whatever makes sense", or at least that's how I would codify what I think we're doing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116198/new/

https://reviews.llvm.org/D116198