[libcxx-commits] [PATCH] D116199: [libc++] Fix ranges::{cbegin, cend} for rvalues.

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Dec 26 12:35:04 PST 2021


jloser added inline comments.


================
Comment at: libcxx/test/std/ranges/range.access/begin.pass.cpp:212
   const BeginFunction aa{};
-  static_assert(!std::invocable<decltype(std::ranges::begin), decltype((a))>);
-  assert(std::ranges::begin(aa) == &aa.x);
+  static_assert(!std::invocable<RangeBeginT, decltype((a))>);
   assert(std::ranges::cbegin(a) == &a.x);
----------------
Is it intentional to have `(a)` instead of `a` in this check? Ditto elsewhere in this file for `invocable` checks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116199/new/

https://reviews.llvm.org/D116199



More information about the libcxx-commits mailing list