[libcxx-commits] [PATCH] D116199: [libc++] Fix ranges::{cbegin, cend} for rvalues.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/__ranges/access.h:178
   };
 }
 
----------------
@philnik wrote:
> You forgot a few closing namespace comments in your commit.

If you're talking about e.g. here (missing the `// namespace __cbegin`), that's intentional — or at least consistent throughout. Everywhere we close one of these nested namespaces after the `};` of a `struct __fn`, we omit the closing comment. I could have //added// closing comments throughout (which would have been consistent with the global rule), but I actually think it looks marginally better without them, so that was a sufficient excuse not to mess with it.

If you're talking about anywhere else, that was unintentional.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116199/new/

https://reviews.llvm.org/D116199