[libcxx-commits] [PATCH] D115599: [libc++][NFC] Mark std::string functions as constexpr

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D115599#3192226 <https://reviews.llvm.org/D115599#3192226>, @ldionne wrote:

> We could prepare the tests for constexpr-friendliness first, and then this would contain both the `_LIBCPP_CONSTEXPR_AFTER_CXX17` and adding
>
>   #if TEST_STD_VER > 17
>       static_assert(tests());
>   #endif
>
> in the test files. If that's doable, that would be ideal, but let me know if that's too much churn.

When I make the tests constexpr-friendly the CI will fail, because functions are marked `constexpr` which are not actually constant evaluatible. So having the tests in a different PR would mean the CI would fail in trunk or the warning has to be disabled in the PR en re-enabled here. I don't think either of these are viable. What should I do?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115599/new/

https://reviews.llvm.org/D115599