[libcxx-commits] [PATCH] D115599: [libc++][NFC] Mark std::string functions as constexpr

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D115599#3192221 <https://reviews.llvm.org/D115599#3192221>, @philnik wrote:

> So you basically want this to contain all the tests and mark the functions as `constexpr`, and make the functional changes first?

We could prepare the tests for constexpr-friendliness first, and then this would contain both the `_LIBCPP_CONSTEXPR_AFTER_CXX17` and adding

  #if TEST_STD_VER > 17
      static_assert(tests());
  #endif

in the test files. If that's doable, that would be ideal, but let me know if that's too much churn.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115599/new/

https://reviews.llvm.org/D115599