[libcxx-commits] [PATCH] D115059: [libcxx][modularisation] completes <memory> modularisation

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/__vector/construct.h:1
+// -*- C++ -*-
+//===----------------------------------------------------------------------===//
----------------
Mordante wrote:
> Quuxplusone wrote:
> > I'm not thrilled by the name of this file, although I can't come up with anything super better, so the current name is not unacceptable AFAIC. //Possibly// `<__vector/construct_range.h>` or `<__vector/construct_helpers.h>` would be better?
> I agree. Alternatively how about splitting this in multiple files?
FWIW, I vote for not splitting this any //further//: all the functionality in here is tightly related. (But I see the counterargument, that the tight relation would still be implied by the fact that everything's under `__vector/`.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115059/new/

https://reviews.llvm.org/D115059