[libcxx-commits] [PATCH] D115059: [libcxx][modularisation] completes <memory> modularisation

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

In general LGTM modulo some minor issues. I'll omit the libc++ approval for now, so we have another look after all issues have been addressed.



================
Comment at: libcxx/include/__functional/builtin_new_allocator.h:18
+
+_LIBCPP_BEGIN_NAMESPACE_STD
+
----------------



================
Comment at: libcxx/include/__memory/swap_allocator.h:18
+
+_LIBCPP_BEGIN_NAMESPACE_STD
+
----------------



================
Comment at: libcxx/include/__vector/construct.h:1
+// -*- C++ -*-
+//===----------------------------------------------------------------------===//
----------------
Quuxplusone wrote:
> I'm not thrilled by the name of this file, although I can't come up with anything super better, so the current name is not unacceptable AFAIC. //Possibly// `<__vector/construct_range.h>` or `<__vector/construct_helpers.h>` would be better?
I agree. Alternatively how about splitting this in multiple files?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115059/new/

https://reviews.llvm.org/D115059