[libcxx-commits] [PATCH] D114912: [libc++] [P1614] Hidden-friend operator<=> for string_view.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Dec 2 05:28:50 PST 2021


ldionne added a comment.

Can you show me how that's non-conforming? I think you've explained it elsewhere but can you post a link if you have one?



================
Comment at: libcxx/include/__compare/comp_cat.h:27
+
+template<class _Traits, class _Dflt, class = void>
+struct __comp_cat {
----------------
jloser wrote:
> What's `_Dflt` short for?  Ditto below in the other alias templates.
I assume it means `_Default`. We should just use that name, it's clearer and those 3 additional characters don't cost a lot.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114912/new/

https://reviews.llvm.org/D114912



More information about the libcxx-commits mailing list