[libcxx-commits] [PATCH] D114912: [libc++] [P1614] Hidden-friend operator<=> for string_view.
Nikolas Klauser via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Dec 2 02:50:21 PST 2021
philnik added inline comments.
================
Comment at: libcxx/test/std/strings/string.view/string.view.comparison/spaceship.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
Quuxplusone wrote:
> philnik wrote:
> > Your formatting seems a bit inconsistent in this file.
> In what sense/where?
> This is formatted the same as the rest of `libcxx/test/std/strings/string.view/string.view.comparison/` (which I just landed recently), so anything I change in here I'll also change in those 6 files.
Ok, my wording was not exactly perfect. It's actually only the braces in lines 37 and 104. Everything else seems Ok.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114912/new/
https://reviews.llvm.org/D114912
More information about the libcxx-commits
mailing list