[libcxx-commits] [PATCH] D107835: [libunwind] Compile with -Wunused-but-set-variable

Fangrui Song via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 31 10:33:58 PDT 2021


MaskRay added a comment.

Looks like the libunwind warning list is stronger than llvm's (scattered in `llvm/cmake/modules/HandleLLVMOptions.cmake`).
I think it is probably fine to not duplicate options which are also set in llvm/.

Perhaps not many groups use standalone builds, so losing some warning options is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107835/new/

https://reviews.llvm.org/D107835



More information about the libcxx-commits mailing list