[libcxx-commits] [PATCH] D107835: [libunwind] Compile with -Wunused-but-set-variable

[David Blaikie via Phabricator via libcxx-commits]

dblaikie added a comment.

In D107835#2974899 <https://reviews.llvm.org/D107835#2974899>, @MaskRay wrote:

> Some users do standalone builds. They use `libunwind/CMakeLists.txt` as the main config, skipping `llvm/CMakeLists.txt`.
>
> `cmake -GNinja -Hlibunwind -B/tmp/out/play` In this setting, some `llvm/CMakeLists.txt` options (e.g. `-fvisibility-inlines-hidden`) are not inherited to libunwind.
>
> Note that libcxx sets its own options as well as inherits options from `llvm/CMakeLists.txt`. I am on the fence whether libunwind should inherit llvm/'s options.

Not an absolute requirement - but I did want to check if it was possible/reasonable. If this is only to support parity in a standalone build, perhaps we should document/comment that the list should be kept in sync with some list in the LLVM build files?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107835/new/

https://reviews.llvm.org/D107835