[libcxx-commits] [PATCH] D105758: Hold mutex lock while notify_all is called at notify_all_at_thread_exit

[Vinícius dos Santos Oliveira via Phabricator via libcxx-commits]

vinipsmaker added a comment.

> At this point I'm inclined to say we should just commit the fix, presumably //without// the attached test case

Well... I can't even use notify_all_at_thread_exit in its current state, and my workaround isn't general enough to cover all cases. Tests should be available to ensure the library is correct, not the other way around. If a test case is just going to guarantee libc++ will be buggy... I don't see the point with a test case at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105758/new/

https://reviews.llvm.org/D105758