[libcxx-commits] [PATCH] D105758: Hold mutex lock while notify_all is called at notify_all_at_thread_exit

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone updated this revision to Diff 365644.
Quuxplusone added a reviewer: lewissbaker.
Quuxplusone added a comment.

Still haven't heard from @lewissbaker , so this //did// fall off my radar. At this point I'm inclined to say we should just commit the fix, presumably //without// the attached test case (because the test case doesn't actually reproduce the bug with libc++ anyway). However, I'm showing the test case in this PR right now, just so that people see what I tried.
Again, this test case does //not// reproduce the bug: it's green both before and after the proposed change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105758/new/

https://reviews.llvm.org/D105758

Files:
  libcxx/docs/Status/Cxx2bIssues.csv
  libcxx/src/thread.cpp
  libcxx/test/std/thread/thread.condition/notify_all_at_thread_exit_lwg3343.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105758.365644.patch
Type: text/x-patch
Size: 4199 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210811/d58ed5d2/attachment.bin>