[libcxx-commits] [PATCH] D103670: [libc++][format] Adds bool formatter.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Aug 8 02:09:07 PDT 2021


Mordante marked 2 inline comments as done.
Mordante added a comment.

Thanks for the review!



================
Comment at: libcxx/test/std/utilities/format/format.functions/locale-specific_form.pass.cpp:257
+  test(STR("yes"), loc, STR("{:L}"), true);
+  test(STR("yes"), loc, STR("{:L}"), true);
+
----------------
vitaut wrote:
> This line is the same as above. Did you mean to test false here?
Indeed, seems a copy-paste error.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103670/new/

https://reviews.llvm.org/D103670



More information about the libcxx-commits mailing list