[libcxx-commits] [PATCH] D103670: [libc++][format] Adds bool formatter.

[Victor Zverovich via Phabricator via libcxx-commits]

vitaut added a comment.

Two minor comments inline, otherwise LGTM.



================
Comment at: libcxx/test/std/utilities/format/format.functions/locale-specific_form.pass.cpp:257
+  test(STR("yes"), loc, STR("{:L}"), true);
+  test(STR("yes"), loc, STR("{:L}"), true);
+
----------------
This line is the same as above. Did you mean to test false here?


================
Comment at: libcxx/test/std/utilities/format/format.functions/locale-specific_form.pass.cpp:273-275
+  test(STR("gültig!!!"), loc_unicode, STR("{:!<9L}"), true);
+  test(STR("_gültig__"), loc_unicode, STR("{:_^9L}"), true);
+  test(STR("   gültig"), loc_unicode, STR("{:>9L}"), true);
----------------
Maybe also test that the default alignment is left?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103670/new/

https://reviews.llvm.org/D103670