[libcxx-commits] [PATCH] D107239: [libcxx] Remove _LIBCPP_HAS_NO_BUILTIN_IS_CONSTANT_EVALUATED

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Aug 2 14:34:31 PDT 2021


Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

FWIW, this looks good to me. (I was initially prepared to disapprove of removing support for weird old compilers, but after seeing the diff, I agree: any compiler that expects to compile a C++20 standard library implementation needs to provide `__builtin_is_constant_evaluated`, full stop. And this patch simplifies the codebase nicely.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107239/new/

https://reviews.llvm.org/D107239



More information about the libcxx-commits mailing list