[libcxx-commits] [PATCH] D107239: [libcxx] Remove _LIBCPP_HAS_NO_BUILTIN_IS_CONSTANT_EVALUATED

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D107239#2920079 <https://reviews.llvm.org/D107239#2920079>, @tschuett wrote:

> Completely up to you. How about a separate header to catch unsupported compilers?

Not too fond of that idea, `__config` seems like a good place, it also does other validations.

> It would document in code the minimal supported compiler versions. At the moment it is some rst file I guess.

Yes at the moment it's https://libcxx.llvm.org/index.html# under `Platform and Compiler Support`. So it would be wise to add some comment in the `.rst` regarding updating the header.

@ldionne how do you feel about validating whether the compiler is supported in `__config`?

If we want this validation I'd rather do it in a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107239/new/

https://reviews.llvm.org/D107239