[libcxx-commits] [PATCH] D101638: [libc++] std::to_address mustn't depend on P::element_type.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/libcxx/utilities/memory/pointer.conversion/to_address.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
zoecarver wrote:
> Is this testing something substantially different than `libcxx/test/std/utilities/memory/pointer.conversion/to_address.pass.cpp`? 
This one tests `_VSTD::__to_address` in all modes; that one tests `std::to_address` in C++20 only.
I think it's important to have some relatively explicit coverage of `__to_address` pre-C++20 (now that its innermost guts are so significantly different in C++20-and-later), and I didn't see any existing coverage for `__to_address` anywhere.
This file //is// intentionally a cut-and-paste of the other one with only the underscores changed (and `constexpr` changed to `TEST_CONSTEXPR` and so on).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101638/new/

https://reviews.llvm.org/D101638