[libcxx-commits] [PATCH] D101638: [libc++] std::to_address mustn't depend on P::element_type.

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added a comment.

Still LGTM. Thanks again for working on this!

> Merge my new tests from D101404 <https://reviews.llvm.org/D101404> — indeed I believe they pass now and D101404 <https://reviews.llvm.org/D101404> might be obsolete (if still maybe containing some good ideas for tech debt reduction).

Great that these are passing now. I know it took a bit of iteration, but I think this is the "right" fix for the problem :) Always satisfying. Anyway, I agree it would probably be good to keep some of the cleanups from the other patch (but as a nfc commit or something).



================
Comment at: libcxx/test/libcxx/utilities/memory/pointer.conversion/to_address.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
Is this testing something substantially different than `libcxx/test/std/utilities/memory/pointer.conversion/to_address.pass.cpp`? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101638/new/

https://reviews.llvm.org/D101638