[libcxx-commits] [PATCH] D101550: [libcxx] Use shell quoting for include flag on Windows

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D101550#2726379 <https://reviews.llvm.org/D101550#2726379>, @mstorsjo wrote:

> Thanks, that explains the "what". (FTR, for both the `-D` options in the example, and the `-I` options here, there's also the possibility to write them joined.)
>
> What I'm still wondering though, is, in which cases does this crop up, as it builds fine in all configs I know of? Is this to avoid issues with some other patch that adds more include dirs?

I'm trying to use the runtimes build on Windows and include libc++ in the build which is where I ran into this issue.

Prior to ea12d779bc238c387511fe7462020f4ecf4a8246 <https://reviews.llvm.org/rGea12d779bc238c387511fe7462020f4ecf4a8246> there was only one `/I` and that change only landed yesterday which likely explains why we haven't seen this earlier?

I tried using the joined form but that didn't work but that may have to be because of the quote placement. We need to use quotes around the path because of spaces (we ran into that issue before) but I'm not sure if the correct joined form is `/I"${LIBCXX_GENERATED_INCLUDE_DIR}"` or `"/I${LIBCXX_GENERATED_INCLUDE_DIR}"`, do you know?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101550/new/

https://reviews.llvm.org/D101550