[libcxx-commits] [PATCH] D101550: [libcxx] Use shell quoting for include flag on Windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D101550#2726200 <https://reviews.llvm.org/D101550#2726200>, @phosek wrote:

> In D101550#2726176 <https://reviews.llvm.org/D101550#2726176>, @mstorsjo wrote:
>
>> Can you explain the issue, including the circumstances where/when the issue occurs, in a bit more detail, I don't quite follow. (We do have CI for windows, in an msvc setting, so it works in some configs at least.)
>
> See the last paragraph on https://cmake.org/cmake/help/v3.13/command/target_compile_options.html, I'll add it to the description as well.

Thanks, that explains the "what". (FTR, for both the `-D` options in the example, and the `-I` options here, there's also the possibility to write them joined.)

What I'm still wondering though, is, in which cases does this crop up, as it builds fine in all configs I know of? Is this to avoid issues with some other patch that adds more include dirs?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101550/new/

https://reviews.llvm.org/D101550