[libcxx-commits] [PATCH] D101437: [libcxx] Run the clang-format and generated-output checks on the "service" queue
Arthur O'Dwyer via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Apr 29 06:19:36 PDT 2021
Quuxplusone updated this revision to Diff 341498.
Quuxplusone added a comment.
add `grep --version` (printf debugging ftw!)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101437/new/
https://reviews.llvm.org/D101437
Files:
libcxx/utils/ci/buildkite-pipeline.yml
libcxx/utils/ci/run-buildbot
Index: libcxx/utils/ci/run-buildbot
===================================================================
--- libcxx/utils/ci/run-buildbot
+++ libcxx/utils/ci/run-buildbot
@@ -130,6 +130,7 @@
libcxxabi/{fuzz,include,src,test} \
| tee ${BUILD_DIR}/clang-format.patch
# Check if the diff is empty, fail otherwise.
+ grep --version
! grep -q '^--- a' ${BUILD_DIR}/clang-format.patch
;;
check-generated-output)
@@ -143,6 +144,7 @@
python3 libcxx/utils/generate_header_inclusion_tests.py
python3 libcxx/utils/generate_header_tests.py
git diff | tee ${BUILD_DIR}/generated_output.patch
+ grep --version
# Check if the diffs are empty, fail otherwise.
! grep -q '^--- a' ${BUILD_DIR}/generated_output.patch || false
# Reject patches that introduce non-ASCII characters or hard tabs.
Index: libcxx/utils/ci/buildkite-pipeline.yml
===================================================================
--- libcxx/utils/ci/buildkite-pipeline.yml
+++ libcxx/utils/ci/buildkite-pipeline.yml
@@ -27,7 +27,7 @@
artifact_paths:
- "**/clang-format.patch"
agents:
- queue: "libcxx-builders"
+ queue: "service"
retry:
automatic:
- exit_status: -1 # Agent was lost
@@ -40,7 +40,7 @@
artifact_paths:
- "**/generated_output.patch"
agents:
- queue: "libcxx-builders"
+ queue: "service"
retry:
automatic:
- exit_status: -1 # Agent was lost
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101437.341498.patch
Type: text/x-patch
Size: 1480 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210429/0049191e/attachment-0001.bin>
More information about the libcxx-commits
mailing list