[libcxx-commits] [PATCH] D101437: [libcxx] Run the clang-format and generated-output checks on the "service" queue

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone commandeered this revision.
Quuxplusone added a reviewer: mstorsjo.
Quuxplusone added a comment.

> Surprisingly, the check-generated-output testcase failed this time around, while it didn't yesterday. Maybe it does rely on something that not all workers in the "service" worker pool have installed?

Link to logs: https://buildkite.com/llvm-project/libcxx-ci/builds/2879#f4496127-b31e-4e94-b3b8-cec119946838
The raw log output starts like this:

  + grep -q '^--- a' /var/lib/buildkite-agent/builds/llvm-project/build/check-generated-output/generated_output.patch
  + grep -rn '[^ -~]' libcxx/include/
  libcxx/include/concepts:1:// -*- C++ -*-
  libcxx/include/concepts:2://===-------------------------- concepts ----------------------------------===//
  libcxx/include/concepts:4:// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
  libcxx/include/concepts:5:// See https://llvm.org/LICENSE.txt for license information.
  libcxx/include/concepts:6:// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
  libcxx/include/concepts:10:#ifndef _LIBCPP_CONCEPTS
  libcxx/include/concepts:11:#define _LIBCPP_CONCEPTS
  libcxx/include/concepts:14:    concepts synopsis

...and so on.
This is the same output I get locally from running `grep -rn '[ ^-~]' ../libcxx/include/concepts` (notice the swapping of `^` and space).
Perhaps this is a known bug?

@mstorsjo, I'm going to commandeer to add `grep --version` to the script and keep poking buildkite until it fails again; with a `--version` in hand, we can at least file a StackOverflow question and see if anyone's ever seen this issue before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101437/new/

https://reviews.llvm.org/D101437