[libcxx-commits] [PATCH] D97572: [libc++] Include <__config_site> from <__config>
Petr Hosek via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Apr 27 23:32:59 PDT 2021
phosek marked an inline comment as done.
phosek added inline comments.
================
Comment at: libcxx/cmake/Modules/HandleLibCXXABI.cmake:57
+ # headers into the right location.
+ set(dst "${LIBCXX_GENERATED_INCLUDE_DIR}/include/c++/v1/${dstdir}/${fpath}")
+ add_custom_command(OUTPUT ${dst}
----------------
muiez wrote:
> Wouldn't this copy the libc++abi headers to `include/c++/v1/include/c++/v1/` (on z/OS for example)? I ask because `LIBCXX_GENERATED_INCLUDE_DIR` is already set to `${LLVM_BINARY_DIR}/include/c++/v1` above. Nonetheless, the old change copies them to include/c++/v1 instead. In other words, was this intended?
This was unintended, thanks for spotting it, I fixed it in rGeea5cbc8583d0857e0a9e429c61f7e87122b4dd6.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97572/new/
https://reviews.llvm.org/D97572
More information about the libcxx-commits
mailing list