[libcxx-commits] [PATCH] D97572: [libc++] Include <__config_site> from <__config>

[Muiez Ahmed via Phabricator via libcxx-commits]

muiez added inline comments.


================
Comment at: libcxx/cmake/Modules/HandleLibCXXABI.cmake:57
+        # headers into the right location.
+        set(dst "${LIBCXX_GENERATED_INCLUDE_DIR}/include/c++/v1/${dstdir}/${fpath}")
+        add_custom_command(OUTPUT ${dst}
----------------
Wouldn't this copy the libc++abi headers to `include/c++/v1/include/c++/v1/` (on z/OS for example)? I ask because `LIBCXX_GENERATED_INCLUDE_DIR` is already set to `${LLVM_BINARY_DIR}/include/c++/v1` above. Nonetheless, the old change copies them to include/c++/v1 instead. In other words, was this intended?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97572/new/

https://reviews.llvm.org/D97572