[libcxx-commits] [libcxx] 4ebb01c - [libcxx] [test] Convert a couple of LIBCXX-WINDOWS-FIXME into XFAIL: windows-dll for known bugs

[Martin Storsjö via libcxx-commits]

Author: Martin Storsjö
Date: 2021-04-27T17:16:04+03:00
New Revision: 4ebb01cbcb3a9566fa0684eac5bdb232d9dc91fe

URL: https://github.com/llvm/llvm-project/commit/4ebb01cbcb3a9566fa0684eac5bdb232d9dc91fe
DIFF: https://github.com/llvm/llvm-project/commit/4ebb01cbcb3a9566fa0684eac5bdb232d9dc91fe.diff

LOG: [libcxx] [test] Convert a couple of LIBCXX-WINDOWS-FIXME into XFAIL: windows-dll for known bugs

These are caused due to inconsistencies regarding always inline in
combination with dllimport. A bug report reference is added next to
each XFAIL line.

Differential Revision: https://reviews.llvm.org/D100789

Added: 
    

Modified: 
    libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
    libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
    libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
    libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
index dbf50c12ff2e..8be36e3bd1fd 100644
--- a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
@@ -8,7 +8,8 @@
 
 // REQUIRES: locale.en_US.UTF-8
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
+// https://llvm.org/PR41018
+// XFAIL: windows-dll
 
 // <locale>
 

diff  --git a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
index 0a255a5b64f7..7e2833b436bc 100644
--- a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
@@ -6,6 +6,9 @@
 //
 //===----------------------------------------------------------------------===//
 
+// https://llvm.org/PR41018
+// XFAIL: windows-dll
+
 // <locale>
 
 // template <class charT> class collate;
@@ -13,8 +16,6 @@
 // int compare(const charT* low1, const charT* high1,
 //             const charT* low2, const charT* high2) const;
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 #include <locale>
 #include <cassert>
 

diff  --git a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
index 2858ab02bffe..777ba4b4c6da 100644
--- a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
@@ -6,6 +6,9 @@
 //
 //===----------------------------------------------------------------------===//
 
+// https://llvm.org/PR41018
+// XFAIL: windows-dll
+
 // <locale>
 
 // template <class charT> class collate;
@@ -14,8 +17,6 @@
 
 //   This test is not portable
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 #include <locale>
 #include <string>
 #include <cassert>

diff  --git a/libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp b/libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp
index 001d834adc75..f912dc63a2e9 100644
--- a/libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp
+++ b/libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp
@@ -6,7 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
+// https://llvm.org/PR41018
+// XFAIL: windows-dll
 
 // <locale>