[libcxx-commits] [libcxx] 53b3c1c - [libcxx] [test] Add a separate 'windows-dll' feature to check for

[Martin Storsjö via libcxx-commits]

Author: Martin Storsjö
Date: 2021-04-27T17:14:59+03:00
New Revision: 53b3c1c5e77bbb2560c8bbb20c4b7c4c61166ffb

URL: https://github.com/llvm/llvm-project/commit/53b3c1c5e77bbb2560c8bbb20c4b7c4c61166ffb
DIFF: https://github.com/llvm/llvm-project/commit/53b3c1c5e77bbb2560c8bbb20c4b7c4c61166ffb.diff

LOG: [libcxx] [test] Add a separate 'windows-dll' feature to check for

This allows distinguishing failures in tests that only fail when libcxx
is linked as a DLL, allowing narrowing down XFAILs (avoiding XPASS errors
if not built as a DLL).

If both enable_shared and enable_static are set, the tests link and use
the shared version of the lib.

Differential Revision: https://reviews.llvm.org/D100221

Added: 
    

Modified: 
    libcxx/utils/libcxx/test/features.py

Removed: 
    


################################################################################
diff  --git a/libcxx/utils/libcxx/test/features.py b/libcxx/utils/libcxx/test/features.py
index 2fb7e003ce03..e90f3c8e81be 100644
--- a/libcxx/utils/libcxx/test/features.py
+++ b/libcxx/utils/libcxx/test/features.py
@@ -153,6 +153,7 @@
 DEFAULT_FEATURES += [
   Feature(name='darwin', when=lambda cfg: '__APPLE__' in compilerMacros(cfg)),
   Feature(name='windows', when=lambda cfg: '_WIN32' in compilerMacros(cfg)),
+  Feature(name='windows-dll', when=lambda cfg: '_WIN32' in compilerMacros(cfg) and not '_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS' in compilerMacros(cfg)),
   Feature(name='linux', when=lambda cfg: '__linux__' in compilerMacros(cfg)),
   Feature(name='netbsd', when=lambda cfg: '__NetBSD__' in compilerMacros(cfg)),
   Feature(name='freebsd', when=lambda cfg: '__FreeBSD__' in compilerMacros(cfg))