[libcxx-commits] [PATCH] D101242: [libcxx][nfc] renames test iterator types to `legacy_*_iterator`

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Apr 25 04:38:31 PDT 2021


Mordante added a comment.

I had a short look at the patch. I also wonder whether this is the direction we want to go.
For reviewing, I assume this is all basically a search and replace? Or are there more changes?



================
Comment at: libcxx/test/support/test_iterators.h:1
 //===----------------------------------------------------------------------===//
 //
----------------
The new C++20 style iterators will they also be put in this file or will they get their own header. If the latter then maybe rename this file to `test_legacy_iterator.h`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101242/new/

https://reviews.llvm.org/D101242



More information about the libcxx-commits mailing list