[libcxx-commits] [PATCH] D99177: [libcxx] [test] Fix testing on windows with c++experimental enabled

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/utils/libcxx/test/features.py:86
+
+  Feature(name='msvc',                                                                                                             when=_isMSVC),
 ]
----------------
ldionne wrote:
> Do we want to also populate the MSVC version like we do for GCC and Clang?
Sure, I can do that for consistency.

In cases when testing with libc++, it's actually Clang impersonating MSVC - but the version of MSVC that Clang tries to impersonate can still be useful to know. (Clang has to emulate certain MSVC bugs depending on the emulated MSVC version at times. And in some cases, whether Clang correctly emulates newer MSVC features, or stopping emulating old MSVC bugs, depends on the Clang version as well.) So in practice, using the version for anything can be tricky/messy, but I can add it in any case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99177/new/

https://reviews.llvm.org/D99177