[libcxx-commits] [PATCH] D99177: [libcxx] [test] Fix testing on windows with c++experimental enabled

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 21 14:38:07 PDT 2021


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM, but please consider populating the version.



================
Comment at: libcxx/utils/libcxx/test/features.py:86
+
+  Feature(name='msvc',                                                                                                             when=_isMSVC),
 ]
----------------
Do we want to also populate the MSVC version like we do for GCC and Clang?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99177/new/

https://reviews.llvm.org/D99177



More information about the libcxx-commits mailing list