[libcxx-commits] [PATCH] D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t`

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked 10 inline comments as done.
ldionne added inline comments.


================
Comment at: libcxx/include/__iterator/iter_move.h:15
+#include <__iterator/concepts.h> // __class_or_enum
+#include <concepts> // __class_or_enum
+#include <type_traits>
----------------
zoecarver wrote:
> Why are these (or at least why does it appear that these) are both importing `__class_or_enum`? (I think only the latter should have the comment.)
It was a typo, fixed.


================
Comment at: libcxx/include/__iterator/iter_move.h:49
+  {
+    return iter_move(_VSTD::forward<_Ip>(__i));
+  }
----------------
zoecarver wrote:
> Non blocking nit: `_LIBCPP_NOEXCEPT_RETURN`?
I'm really not a big fan of that macro, and it's only defined locally when defining `__apply_tuple_impl`. Not doing.


================
Comment at: libcxx/include/concepts:445
 
-#endif //_LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_CONCEPTS)
+#endif // _LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_CONCEPTS)
 
----------------
zoecarver wrote:
> Non blocking, nit: `_LIBCPP_HAS_NO_RANGES`
Actually, this line isn't touched anymore after rebase, so not changing anything.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99873/new/

https://reviews.llvm.org/D99873