[libcxx-commits] [PATCH] D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t`

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added inline comments.


================
Comment at: libcxx/include/iterator:439
 
+#if !defined(_LIBCPP_HAS_NO_RANGES)
+#   include <__iterator/iter_move.h>
----------------
zoecarver wrote:
> I'd rather have this be such that we can import any libc++ header and it will guard against the correct stdlib version, etc. internally. This is how we do it for other "versioning" features, I think we should do it with this, too. 
> 
> In other words, I'd rather have the `_LIBCPP_HAS_NO_RANGES` check inside of `iter_move.h`.
+10. This is already causing me issues downstream where I only import headers that expose the necessary names.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99873/new/

https://reviews.llvm.org/D99873