[libcxx-commits] [PATCH] D97538: [libcxx] [test] Ifdef out tests that rely on perms::none on directories for triggering errors

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

This LGTM, but can we perhaps define a macro like `TEST_WIN_NO_FAILURES_WITH_PERMISSIONS` defined when `_WIN32` is defined (pick a better name) and use that instead? Just to avoid sprinkling naked `_WIN32`'s in the test suite if we can. No need for review either way, but please consider my suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97538/new/

https://reviews.llvm.org/D97538